qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6620) [Java Broker] Restore the behaviour of the if(LOGGER.isDebugEnabled()) idiom (but restrict its use)
Date Sun, 05 Jul 2015 17:47:04 GMT

    [ https://issues.apache.org/jira/browse/QPID-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614332#comment-14614332
] 

ASF subversion and git services commented on QPID-6620:
-------------------------------------------------------

Commit 1689268 from [~godfrer] in branch 'java/trunk'
[ https://svn.apache.org/r1689268 ]

QPID-6620 : [Java Broker] restore isDebugEnabled functionality but use it more sparingly

> [Java Broker] Restore the behaviour of the if(LOGGER.isDebugEnabled()) idiom (but restrict
its use)
> ---------------------------------------------------------------------------------------------------
>
>                 Key: QPID-6620
>                 URL: https://issues.apache.org/jira/browse/QPID-6620
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: 6.0 [Java]
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: 6.0 [Java]
>
>
> Recent changes to the logging mechanism in the broker mean that us of the idiom
> {code}
> if(_logger.isDebugEnabled())
> {
>     _logger.debug(...)'
> }
> {code}
> no longer prevents the debug statement being evaluated when debug logging is not switched
on.
> In order to restore this behaviour we need to add a "TurboFilter" which can evaluate
whether the logger will actually log the statement.
> Additionally we should reduce the use of this idiom and instead use the ability of logback/slf4j
to use patterns with parameters rather than dynamically building up the logged string.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message