qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lorenz Quack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6623) [Java Broker] Log a warning before creating a new configuration secret key file
Date Wed, 08 Jul 2015 09:12:04 GMT

    [ https://issues.apache.org/jira/browse/QPID-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618268#comment-14618268

Lorenz Quack commented on QPID-6623:

The change looks correct to me as well.
However, with my pedantic review hat on I have a couple of nitpicks which you are free to
 * Encryption should be lower cased
 * The file location should be enclosed by quotes.
 * There should be a full stop at the end of the sentence
 * There should be a space between the function arguments

{code}LOGGER.warn("Configuration encryption is enabled, but no configuration secret was found.
A new configuration secret will be created at '{}'.", fileLocation);{code}

> [Java Broker] Log a warning before creating a new configuration secret key file
> -------------------------------------------------------------------------------
>                 Key: QPID-6623
>                 URL: https://issues.apache.org/jira/browse/QPID-6623
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: 6.0 [Java]
> When starting the broker cannot distinguish between the case of configuration which has
been changed by hand to add a configuration secret encrypter (in which case the correct answer
is to simply create a new key file), or where the key file has been accidentally deleted.
 A log warning should be emitted so that if a subsequent issue arises operators can determine
that a new keyfile was generated/

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message