qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "michael goulish" <mgoul...@redhat.com>
Subject Re: Review Request 36992: PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants
Date Wed, 05 Aug 2015 09:52:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36992/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 9:52 a.m.)


Review request for qpid, Kenneth Giusti and Ted Ross.


Changes
-------

Improvements from kgiusti's feedback.


Repository: qpid-proton-git


Description
-------

PROTON-886 and PROTON-930 -- handle_max and AMQP numeric default constants.  

    Note:
    {
      I am skipping the java implementation for now,
      because I would like to get the C version out of
      my life.  (And this diff is already quite large
      enough, I think.)

      I will write a separate JIRA for the java version
      and make it refer to this one.  I will work on it
      as a background task.
    }

    This diff adds two pieces of functionality:

      1. extract numeric default valuies from AMQP
         xml files and store them as defined constants
         in protocol.h  (PROTON_930)

      2. add code to enforce AMQP 1.0 spec mandated
         behavior with respect to handle-max values
         -- i.e. negotiated limits on number of links --
         per session.  (PROTON-886)

    These two changes are combined into one checkin
    because of some earlier feedback I got suggesting
    that I not check in PROTON-930 until I had some
    code that could actually use the constants that it
    creates.

    The code that is generated by the changes in
    proton-c/src/protocol.h.py show up in the file
    protocol.h.  It is this:

    --------- begin snippet -----------------------
    /* Numeric default values */
    #define AMQP_OPEN_MAX_FRAME_SIZE_DEFAULT 4294967295
    #define AMQP_OPEN_CHANNEL_MAX_DEFAULT 65535
    #define AMQP_BEGIN_HANDLE_MAX_DEFAULT 4294967295
    #define AMQP_SOURCE_TIMEOUT_DEFAULT 0
    #define AMQP_TARGET_TIMEOUT_DEFAULT 0
    --------- end snippet -----------------------


Diffs (updated)
-----

  proton-c/bindings/python/proton/__init__.py 46b9466 
  proton-c/include/proton/session.h 94d2869 
  proton-c/src/engine/engine-internal.h 727f50d 
  proton-c/src/engine/engine.c 9043e0b 
  proton-c/src/protocol.h.py bbc0dfe 
  proton-c/src/transport/transport.c 6abf862 
  tests/python/proton_tests/engine.py 7a1d539 

Diff: https://reviews.apache.org/r/36992/diff/


Testing
-------

ctest -VV with Java tests running.


Thanks,

michael goulish


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message