qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gordon Sim" <g...@redhat.com>
Subject Re: Review Request 37553: Use the monotonic clock to compute the AMQP1.0 idle timer interval
Date Tue, 18 Aug 2015 07:49:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37553/#review95695
-----------------------------------------------------------

Ship it!


Fix for the broker seems fine. Perhaps the client should have a similar change? Long running
clients would have the same issue.

I do also think that the Time.h should be modified/augmented somehow to make issues like this
clearer. E.g. a Duration::FromZero() alongside the FromEpoch with clear advice as to which
to use when? The AbsTime::epoch() method subtracts a FromEpoch duration, computed using the
realtime clock, from the now() which is computed from the monotonic clock. Is that even valid?
These are arguably separate issues though, just raising tnem for debate.

- Gordon Sim


On Aug. 17, 2015, 8:34 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37553/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 8:34 p.m.)
> 
> 
> Review request for qpid and Gordon Sim.
> 
> 
> Bugs: qpid-6698
>     https://issues.apache.org/jira/browse/qpid-6698
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Summary says it all
> 
> 
> Diffs
> -----
> 
>   trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1694323 
> 
> Diff: https://reviews.apache.org/r/37553/diff/
> 
> 
> Testing
> -------
> 
> unit tests
> reproduced via changing wall clock time directly
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message