qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3521) failover process for the 0-8 client does not clear the pre-dispatch queue
Date Mon, 03 Aug 2015 16:10:04 GMT

    [ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652040#comment-14652040
] 

Keith Wall commented on QPID-3521:
----------------------------------

A couple of comments:


# Code changes seem to make a functional change to the 0-10 Connection#stop path, but this
is not called out in the JIRA.  I suggest a new JIRA describing the issue/user impact is appropriate.
# I like the fact that we are now testing failover + connectio#stop, but it is the test assumes
internals of the Java Broker (the  statistic unacknowledgedMessages) and this is distasteful,
as is spreading knowledge of the management interfaces across the test suite.  Why is it not
sufficient countdown after the message listener's Connection#stop and kill the Broker to cause
failover?
# AMQSession#stopExistingDispatcher is a check then act with the risk of a NPE if _dispatcher
is nulled between. Copy the reference and then use the copy.
# AMQSession#drainDispatchQueueWithDispatcher use a try/finally to help ensure that the dispatcher
cleanup flag is always returned to its unset state.


> failover process for the 0-8 client does not clear the pre-dispatch queue
> -------------------------------------------------------------------------
>
>                 Key: QPID-3521
>                 URL: https://issues.apache.org/jira/browse/QPID-3521
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Robbie Gemmell
>            Assignee: Keith Wall
>              Labels: failover
>         Attachments: clear-dispatch-queue-on-failover.diff
>
>
> failover process for the 0-8 client does not clear the pre-dispatch queue, only the consumer
receive queue.
> This is currently masked by an issue with the rollbackMark. The changes made in QPID-3546
to fix the 0-10 client path need to be applied to the 0-8/9/9-1 client path when this issue
is resolved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message