qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Godfrey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3521) failover process for the 0-8 client does not clear the pre-dispatch queue
Date Wed, 05 Aug 2015 19:39:05 GMT

    [ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658742#comment-14658742
] 

Rob Godfrey commented on QPID-3521:
-----------------------------------

What's the rationale for adding the ConnectionHelper class - moving the functionality from
AMQConnection to a static method which then operates on the connection?

Refactoring in this way doesn't seem to add any tangible benefits and seems simply to move
methods from the class they affect to a separate file.

There's certainly a lot of valuable refactoring that could be done around the client... but
I'm not sure this is really an improvement

> failover process for the 0-8 client does not clear the pre-dispatch queue
> -------------------------------------------------------------------------
>
>                 Key: QPID-3521
>                 URL: https://issues.apache.org/jira/browse/QPID-3521
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Robbie Gemmell
>            Assignee: Alex Rudyy
>              Labels: failover
>         Attachments: clear-dispatch-queue-on-failover.diff
>
>
> failover process for the 0-8 client does not clear the pre-dispatch queue, only the consumer
receive queue.
> This is currently masked by an issue with the rollbackMark. The changes made in QPID-3546
to fix the 0-10 client path need to be applied to the 0-8/9/9-1 client path when this issue
is resolved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message