qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-3521) failover process for the 0-8 client does not clear the pre-dispatch queue
Date Thu, 06 Aug 2015 10:00:06 GMT

    [ https://issues.apache.org/jira/browse/QPID-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659776#comment-14659776
] 

Alex Rudyy commented on QPID-3521:
----------------------------------

The rational behind moving functionality from AMQConnection#doWithAllLocks(Runnable) into
ConnectionHelper#doWithAllConnectionAndSessionLocks(Runnable) was to be able to run 0.8 failover
with the all locks acquired without introduction of public method on AMQConnection or changing
visibility to public for AMQConnection#doWithAllLocks(Runnable). 

At the moment we are considering to get rid of ConnectionHelper by either of following:
1) Restoring AMQConnection#doWithAllLocks(Runnable) and introduction of additional interface
on AMQProtocolHandler with a single method responsible for failover running and having private
implementation on AMQConnection which can be passed into AMQProtocolHandler constructor as
a parameter
2) Restoring AMQConnection#doWithAllLocks(Runnable) and moving FailoverHandler into AMQConnection
package, thus it can call  AMQConnection#doWithAllLocks

> failover process for the 0-8 client does not clear the pre-dispatch queue
> -------------------------------------------------------------------------
>
>                 Key: QPID-3521
>                 URL: https://issues.apache.org/jira/browse/QPID-3521
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Robbie Gemmell
>            Assignee: Alex Rudyy
>              Labels: failover
>         Attachments: clear-dispatch-queue-on-failover.diff
>
>
> failover process for the 0-8 client does not clear the pre-dispatch queue, only the consumer
receive queue.
> This is currently masked by an issue with the rollbackMark. The changes made in QPID-3546
to fix the 0-10 client path need to be applied to the 0-8/9/9-1 client path when this issue
is resolved.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message