qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6695) Make model tasks have useful toStrings so that task submit/completion debug logs are useful
Date Fri, 14 Aug 2015 16:02:46 GMT

    [ https://issues.apache.org/jira/browse/QPID-6695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697288#comment-14697288
] 

Keith Wall commented on QPID-6695:
----------------------------------

The approach that looks most appealing is to enhance Task so it is capable of encapsulating
the action, the subject and object of the action.  TaskExecutor implementation would then
be changed to log these details in a standard fashion.  However, this change is impeded by
the variety of ways in which we represent actions; sometimes we use Task, sometimes Callback,
sometimes Runnable.    On some code paths, Callables are wrapped in Tasks only to be wrapped
in Callbacks again!  This makes giving consistent logging more difficult.  It seems that refactoring
TaskExcecutor is the logical place to start.


> Make model tasks have useful toStrings so that task submit/completion debug logs are
useful
> -------------------------------------------------------------------------------------------
>
>                 Key: QPID-6695
>                 URL: https://issues.apache.org/jira/browse/QPID-6695
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>
> At the moment, when running the Broker at debug, we currently write the following as
each task is submitted to the task executor:
> {noformat}
> 2015-07-31 15:29:45,096 DEBUG [VirtualHostNode-bdb-Config] (o.a.q.s.c.u.TaskExecutorImpl)
- Task org.apache.qpid.server.model.AbstractConfiguredObject$2@201982d
> is performed successfully with result: null
> 2015-07-31 15:29:45,116 DEBUG [VirtualHostNode-bdb-Config] (o.a.q.s.c.u.TaskExecutorImpl)
- Task org.apache.qpid.server.model.AbstractConfiguredObject$2@73dc353
> 4 is performed successfully with result: null
> {noformat}
> The ability to diagnose errors would be improved if the logging were improved to include
the details of the operation and the action being performed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message