qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "michael goulish" <mgoul...@redhat.com>
Subject Review Request 38439: PROTON-992 : introduce pn_init() fn
Date Wed, 16 Sep 2015 18:26:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38439/
-----------------------------------------------------------

Review request for qpid, Alan Conway, Kenneth Giusti, and Ted Ross.


Repository: qpid-proton-git


Description
-------

PROTON-992 : introduce a pn_init() fn, so we can initialize things like Cyrus SASL exactly-once.
 
New file proton.h to hold declaration, because this doesn't seem to fit anywhere else.
There is a flag in the sasl code to show whether this new interface has been used or not.
If not -- allow code to function as before.  Don't require current proton apps to change.


Diffs
-----

  proton-c/include/proton/proton.h PRE-CREATION 
  proton-c/src/sasl/cyrus_sasl.c 809bad5 
  proton-c/src/sasl/none_sasl.c 674326f 
  proton-c/src/sasl/sasl-internal.h b3f4c7f 
  proton-c/src/util.c e2c6727 

Diff: https://reviews.apache.org/r/38439/diff/


Testing
-------

ctest -VV to confirm that not using the new interface does not break anything.

And I hacked a copy of dispatch router to make it call the new pn_init() from main -- and
confirm that the cyrus sasl server init and client init fns are called exactly once.


Thanks,

michael goulish


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message