qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chug Rolke" <cro...@redhat.com>
Subject Re: Review Request 38863: Add toggle to control sasl layer to proton.reactor.Container
Date Wed, 30 Sep 2015 13:06:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38863/#review101114
-----------------------------------------------------------

Ship it!


This fixes the specific self-test failure in dispatch. I have not tested whether it's possible
to set the reactor sasl_layer switch through all the layers between proton/reactor and dispatch/qdstat.

- Chug Rolke


On Sept. 29, 2015, 9:56 p.m., Gordon Sim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38863/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 9:56 p.m.)
> 
> 
> Review request for qpid, Justin Ross and Ted Ross.
> 
> 
> Bugs: PROTON-1008
>     https://issues.apache.org/jira/browse/PROTON-1008
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> There is no direct and easy way to control whether a sasl layer is used or not that works
for all cases. Prior to the 0.10 release, specifying a username was the trigger to enable
sasl. However for EXTERNAL or GSSAPI that doesn't work as well. This patch proposes adding
an explicit toggle to either enable or disable the use of sasl. It is enabled by default (ANONYMOUS
is then a simple way of avoiding actual authentication if not needed), but can be disabled
at the container- or connection- level.
> 
> For consistency I've also allowec connection level overrding of the allowed_mechs and
allow_insecure_mechs options.
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/python/proton/reactor.py 8de5d89 
> 
> Diff: https://reviews.apache.org/r/38863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gordon Sim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message