qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6736) Rewrite 0-8..0-91 connection / session units tests
Date Mon, 14 Sep 2015 10:25:46 GMT

    [ https://issues.apache.org/jira/browse/QPID-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743333#comment-14743333
] 

Alex Rudyy commented on QPID-6736:
----------------------------------

Keith,
One thing I would do differently is how context variable values are get evaluated: instead
of calling connection.getBroker().getContextValue(...) or connection.getVirtualHost().getContextValue(...)
I would change AMQChannel to call connection.getContextValue(...). In that case, we could
get rid of public method getBroker() and extra unnecessary steps in test setups to mock for
broker and virtual host.

Apart from above the rest of changes look reasonable to me.

> Rewrite 0-8..0-91 connection / session units tests
> --------------------------------------------------
>
>                 Key: QPID-6736
>                 URL: https://issues.apache.org/jira/browse/QPID-6736
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Tests
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>            Priority: Minor
>             Fix For: qpid-java-6.0
>
>
> Current tests rely on a test-only implementation of AMQConnection_0_8 (InternalTestProtocolSession)
which makes it difficult to know if a test is testing production or test-only code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message