qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-163) Add username and password for authentication of connectors
Date Tue, 20 Oct 2015 17:40:27 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965442#comment-14965442
] 

ASF GitHub Bot commented on DISPATCH-163:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/21#discussion_r42527876
  
    --- Diff: tests/CMakeLists.txt ---
    @@ -61,20 +73,22 @@ add_test(unit_tests_size_3     ${TEST_WRAP} --vg unit_tests_size 3)
     add_test(unit_tests_size_2     ${TEST_WRAP} --vg unit_tests_size 2)
     add_test(unit_tests_size_1     ${TEST_WRAP} --vg unit_tests_size 1)
     add_test(unit_tests            ${TEST_WRAP} --vg unit_tests ${CMAKE_CURRENT_SOURCE_DIR}/threads4.conf)
    -add_test(router_tests          ${TEST_WRAP} -s ${CMAKE_CURRENT_SOURCE_DIR}/router_engine_test.py
-v)
    -add_test(management_tests      ${TEST_WRAP} -m unittest -v management)
    -
    -macro(add_system_test test)
    -  add_test(${test} ${TEST_WRAP} -m ${test} -v)
    -endmacro(add_system_test)
     
    -add_system_test(system_tests_broker)
    -add_system_test(system_tests_management)
    -add_system_test(system_tests_one_router)
    -add_system_test(system_tests_qdmanage)
    -add_system_test(system_tests_qdstat)
    -add_system_test(system_tests_two_routers)
    -add_system_test(system_tests_link_routes)
    +# Add all sytem_tests* using add_test
    +add_test(router_tests             ${TEST_WRAP} -s ${CMAKE_CURRENT_SOURCE_DIR}/router_engine_test.py
-v)
    +add_test(system_tests_broker      ${TEST_WRAP} -s ${CMAKE_CURRENT_BINARY_DIR}/system_tests_broker.py
-v)
    --- End diff --
    
    Why do you move the tests to the build folder when you could simply run them from the
source folder here?  Then you could run the "configured" tests from the build folder and the
non-configured ones from the source folder.


> Add username and password for authentication of connectors
> ----------------------------------------------------------
>
>                 Key: DISPATCH-163
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-163
>             Project: Qpid Dispatch
>          Issue Type: New Feature
>          Components: Container
>            Reporter: Ted Ross
>            Assignee: Ganesh Murthy
>             Fix For: 0.6
>
>
> Currently, connectors cannot use PLAIN authentication because there is no configuration
for username and password.  This needs to be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message