qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ted-ross <...@git.apache.org>
Subject [GitHub] qpid-dispatch pull request: DISPATCH-179 - Added boilerplate code ...
Date Wed, 18 Nov 2015 22:06:46 GMT
Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/34#discussion_r45268045
  
    --- Diff: include/qpid/dispatch/router_core.h ---
    @@ -262,7 +262,7 @@ void qdr_manage_create(qdr_core_t *core, void *context, qd_router_entity_type_t
      * @param identity The identity supplied with the request (or 0 if the name was supplied)
      */
     void qdr_manage_delete(qdr_core_t *core, void *context, qd_router_entity_type_t type,
    -                       qd_field_iterator_t *name, qd_field_iterator_t *identity);
    +                       qd_field_iterator_t *name, qd_field_iterator_t *identity, qd_composed_field_t
*body);
    --- End diff --
    
    Why do you need this?  The body is always an empty map.  I don't see any need to pass
it into the core.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message