qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-179) Refactor Router Core
Date Mon, 23 Nov 2015 15:05:11 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022222#comment-15022222

ASF GitHub Bot commented on DISPATCH-179:

Github user ted-ross commented on a diff in the pull request:

    --- Diff: include/qpid/dispatch/router_core.h ---
    @@ -322,5 +322,5 @@ void qdr_query_free(qdr_query_t *query);
     typedef void (*qdr_manage_response_t) (void *context, const qd_amqp_error_t *status,
bool more);
     void qdr_manage_handler(qdr_core_t *core, qdr_manage_response_t response_handler);
    +bool qdr_is_set_manage_handler(qdr_core_t *core);
    --- End diff --
    I don't think this is needed.  The "outer" agent should register its callbacks once at
initialization time.  It is not safe to register new handlers for each request that comes
in and it's not necessary to repeatedly register the same handler.

> Refactor Router Core
> --------------------
>                 Key: DISPATCH-179
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-179
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Router Node
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>             Fix For: 0.6
> Refactor the core router function to clean up the architecture and to fix the significant
lock contention issue that exists in 0.5.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message