qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-6831) Remove logging from constructor of ConnectionScopedRuntimeException
Date Tue, 17 Nov 2015 15:32:11 GMT

     [ https://issues.apache.org/jira/browse/QPID-6831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alex Rudyy updated QPID-6831:
-----------------------------
    Status: Open  (was: Reviewable)

Since you started removal of TransportException from try-catch blocks, it seems we can remove
catching of TransportException from the following methods:
org.apache.qpid.server.queue.AbstractQueue#tryDeliverStraightThrough
org.apache.qpid.server.protocol.v0_8.AMQPConnection_0_8#closed

RuntimeMBeanException are logged with ERROR log level whilst before they were logged with
DEBUG. Thus, such exceptions like "exchange already exists", "queue already exists", etc will
be reported with ERROR severity. IMHO, that would result in false ERROR alerts by monitoring
tool/etc.

> Remove logging from constructor of ConnectionScopedRuntimeException
> -------------------------------------------------------------------
>
>                 Key: QPID-6831
>                 URL: https://issues.apache.org/jira/browse/QPID-6831
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>            Priority: Minor
>             Fix For: qpid-java-6.0
>
>
> {{ConnectionScopedRuntimeException}} currently logs itself at ERROR, with a complete
stacktrace, on construction.  The CSRE is intended to be used when the Broker detects an abnormal
situation which should  cause only the affected connection to be closed, for instance, a badly
composed frame.
> The responsibility for logging the CSRE need to be taken higher up the stack, so it can
chose the appropriate level of detail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message