qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lorenz Quack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-6869) Add system test that ensures messaging is reliable when the client is disconnected abraptly or killed
Date Fri, 20 Nov 2015 15:37:11 GMT

    [ https://issues.apache.org/jira/browse/QPID-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018163#comment-15018163
] 

Lorenz Quack commented on QPID-6869:
------------------------------------

Hi Alex. I looked at your commit. Seems good to me. Just a few comments. Mainly nit-picking
about names.
* In {{TCPTunneler}}
** The order and name of arguments changes between the constructors of {{TCPTunneler}} and
{{TCPWorker}}. I think it would be nicer if they were the same.
** In {{TCPWorker}} the member {{_hostPort}} should rather be {{_remoteAddress}} or {{_targetAddress}
or something similar.
** The naming is not consistent. {{proxyPort}} vs {{localPort}}; {{hostPort}} vs {{targetHost
+ ":" targetPort}} vs {{serverSocket}} If you go with {{localPort}} I would suggest {{remotePort/Host}}
** I don't see a reason for the {{NoopTunnelListener}}. Both usages of it override all methods
so they would be better served implementing {{TunnelListener}}. 
** There are two different entities with IMHO too similar names: {{_serverSocket}} in {{TCPWorker}}
which accepts connections from the client and the local {{serverSocket}} in {{TCPWorker#createTunnel}}
which is the socket which connects to the server.
** In {{SocketTunnel}} I find the names {{_inputStreamForwarder}} (from client to server)
and {{_outputStreamForwarder}} (from server to client) unintuitive. Maybe {{upstreamForwarder}}
and {{downstreamForwarder}}?
** {{ClosableStreamForwarder}} is not really a {{Closable}}. Maybe {{AutoClosingStreamForwarder}}?
* In {{AbruptClientDisconnectTest}}
** The use of {{wait()}} and {{notify()}} in {{Producer}} for sleeping is not reliable due
to spurious wake-ups. Since this feature does not seem to be used. Maybe it's best to remove
it.
** The handling of InterruptException in {{Producer#stop}} and {{Consumer#stop}} seems to
miss the restoring of the interrupt flag by calling {{Thread.currentThread().interrupt()}}


> Add system test that ensures messaging is reliable when the client is disconnected abraptly
or killed
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-6869
>                 URL: https://issues.apache.org/jira/browse/QPID-6869
>             Project: Qpid
>          Issue Type: Test
>          Components: Java Tests
>            Reporter: Alex Rudyy
>            Assignee: Lorenz Quack
>             Fix For: qpid-java-6.0
>
>
> Add system test that tests messaging functionality on abrupt java client disconnect (kill)
whilst it is sending and receiving messages.
> Usable from both the IDE and Maven.
> Probably configured from the command line (broker, queue etc)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message