qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (QPID-5738) [Java Broker] AbstractConfigureObject#setAttribute() does not validate attributes
Date Sun, 17 Jan 2016 09:00:46 GMT

     [ https://issues.apache.org/jira/browse/QPID-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Keith Wall updated QPID-5738:
-----------------------------
    Attachment: 0001-QPID-5738-Java-Broker-Model-remove-setAttribute-and-.patch

Complete working patch.  Calls to setAttribute replaced with setAttributes.  Call to validateChange
bracketed with if (!SecurityManager.isSystemProcess()) to allow use cases where the system
needs to break it own business rules (such as AbstractQueue#onCreate which changes the durable
flag.

This is intended for 6.1.0, but will hold off committing whilst 6.0.1 is having is finishing
touches.

> [Java Broker] AbstractConfigureObject#setAttribute() does not validate attributes
> ---------------------------------------------------------------------------------
>
>                 Key: QPID-5738
>                 URL: https://issues.apache.org/jira/browse/QPID-5738
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: 0.29
>            Reporter: Keith Wall
>            Assignee: Rob Godfrey
>         Attachments: 0001-QPID-5738-Java-Broker-Model-remove-setAttribute-and-.patch,
setAttributeRefactor.patch
>
>
> Code path ACO#setAttribute omits to invoke the attribute validation facilities of ACO.
  This means that there are circumstances (mainly via the JMX interface) where an unvalidated
attribute value can be set on a configured object.
> We decided that in the short term, ACO#setAttribute() should delegate to its pluralised
version (which does validate attributes).    We tried, I found a couple of tests fell foul
of the validations and needed remediated.  The problem also highlighted AbstractQueue's exclusive
attribute, whose validations appears to need need some work to conform to the new model.
> WIP patch attached.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message