qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-207) When a message body of [ ] is sent from rhea it is rejected as an invalid body
Date Fri, 05 Feb 2016 21:17:39 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135016#comment-15135016
] 

ASF GitHub Bot commented on DISPATCH-207:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/43#discussion_r52073887
  
    --- Diff: src/message.c ---
    @@ -318,8 +318,10 @@ static int qd_check_and_advance(qd_buffer_t         **buffer,
         int pre_consume = 1;  // Count the already extracted tag
         int consume     = 0;
         unsigned char tag = next_octet(&test_cursor, &test_buffer);
    -    if (!test_cursor) return 0;
    -    switch (tag & 0xF0) {
    +    int tag_bit = tag & 0xF0;
    --- End diff --
    
    This looks ok.  One minor change that's needed:  tag is an unsigned char, so tag_bit must
be of the same type.  Also, 0xF0 represents 4 bits so tag_bit might not be the best name.
 The spec calls it a subcategory.  Maybe use that.


> When a message body of [ ] is sent from rhea it is rejected as an invalid body 
> -------------------------------------------------------------------------------
>
>                 Key: DISPATCH-207
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-207
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Management Agent
>    Affects Versions: 0.5
>            Reporter: Ernest Allen
>
> When using rhea to send a management GET-SCHEMA request, a message body of [ ] is expected.

> However, an error is raised: ERROR (error) Invalid message: Invalid body value
> I originally thought this was raising an exception and the router was becoming unresponsive,
but I can't reproduce that behavior.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message