qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Jansen <cliffjan...@gmail.com>
Subject Review Request 44927: C++ api changes: handler options become link or connection options
Date Wed, 16 Mar 2016 20:42:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44927/
-----------------------------------------------------------

Review request for qpid and Justin Ross.


Bugs: PROTON-1138
    https://issues.apache.org/jira/browse/PROTON-1138


Repository: qpid-proton-git


Description
-------

handler options -> link/connection options
prefetch -> credit_window
stop use of pn_flowcontroller (manage credit directly)
override -> update (C++ semi-reserved word) and private
new link_context to store behaviors
have container link_options apply to remote opened links


Diffs
-----

  proton-c/bindings/cpp/include/proton/connection_options.hpp 71e12f1 
  proton-c/bindings/cpp/include/proton/container.hpp 0af1963 
  proton-c/bindings/cpp/include/proton/handler.hpp 3bc0023 
  proton-c/bindings/cpp/include/proton/link.hpp e626398 
  proton-c/bindings/cpp/include/proton/link_options.hpp 2eb145d 
  proton-c/bindings/cpp/src/connection_options.cpp a5ee99e 
  proton-c/bindings/cpp/src/container.cpp fc34f39 
  proton-c/bindings/cpp/src/container_impl.hpp d1b476f 
  proton-c/bindings/cpp/src/container_impl.cpp 55547ca 
  proton-c/bindings/cpp/src/contexts.hpp b4fcdba 
  proton-c/bindings/cpp/src/contexts.cpp c2b76f6 
  proton-c/bindings/cpp/src/handler.cpp 43febf5 
  proton-c/bindings/cpp/src/link_options.cpp 534a6b6 
  proton-c/bindings/cpp/src/messaging_adapter.hpp a5b364a 
  proton-c/bindings/cpp/src/messaging_adapter.cpp 4265644 
  proton-c/bindings/cpp/src/proton_event.hpp 8dd2f8f 
  tests/tools/apps/cpp/reactor_send.cpp 3ba26e8 

Diff: https://reviews.apache.org/r/44927/diff/


Testing
-------

linux build and ctest


Thanks,

Cliff Jansen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message