qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kim van der Riet <kim.vdr...@redhat.com>
Subject Review Request 44967: Add operator<< to proton::byte_array (and hence to decimal32, decimal64 and decimal128)
Date Thu, 17 Mar 2016 17:34:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44967/
-----------------------------------------------------------

Review request for qpid and Alan Conway.


Bugs: PROTON-1159
    https://issues.apache.org/jira/browse/PROTON-1159


Repository: qpid-proton-git


Description
-------

proton::byte_array currently has no method to stream values. To help with qpid-interop-test,
a basic version of operator<<() which returns a hex representation of the byte array
in the format "0xNNNNNN" of the appropriate length is suggested. The decimal classes use "decimalXX(0xNNNN)"
as their format.

An bug in proton::uuid::operator<<() is also presented in which bytes > 0x80 within
the UUID sequence (negative char values) print as ffffffnn rather than nn.


Diffs
-----

  proton-c/bindings/cpp/include/proton/byte_array.hpp fe3f864 
  proton-c/bindings/cpp/src/decimal.cpp 93fe84c 
  proton-c/bindings/cpp/src/uuid.cpp f224df7 

Diff: https://reviews.apache.org/r/44967/diff/


Testing
-------

Works as expected in qpid-interop-test.


Thanks,

Kim van der Riet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message