qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Stitcher <astitc...@apache.org>
Subject Re: Review Request 45288: Change on_message(event&, message&) to add delivery&
Date Thu, 24 Mar 2016 14:32:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45288/
-----------------------------------------------------------

(Updated March 24, 2016, 2:32 p.m.)


Review request for qpid, Alan Conway, Cliff Jansen, and Justin Ross.


Bugs: PROTON-1164
    https://issues.apache.org/jira/browse/PROTON-1164


Repository: qpid-proton-git


Description
-------

- New signature is on_message(event&, delivery&, message&)
- Also simplify other delivery handlers by adding session(), connection() accessors


Diffs
-----

  examples/cpp/broker.hpp ba9040ceec06b947a11edbbca0661bc20877766c 
  examples/cpp/client.cpp c2ec499fe8963cff5cdacf4ed1243331cd83aff3 
  examples/cpp/direct_recv.cpp b2df2ccd859a4f5e75bff50553766694f6abe992 
  examples/cpp/direct_send.cpp 12ba70e9df77bd7d82330aacad1b325ccbf6d944 
  examples/cpp/engine/client.cpp 2b222885b112d06288a16e3166cfdbb924da53d0 
  examples/cpp/engine/direct_recv.cpp 485765b4fe5ba0939eb4fe65e79cbf9a6b714274 
  examples/cpp/engine/direct_send.cpp f87681000a66fc2c641c22b59b15515afe436b81 
  examples/cpp/engine/helloworld.cpp d146ae92c84521bb417eb63e56766efc0d93df46 
  examples/cpp/engine/server.cpp 02c3ac9f5781c87351e8d63143bbae7400efd981 
  examples/cpp/engine/simple_recv.cpp bc17c5fc9d717d9be754de8c2c28aedf45565db8 
  examples/cpp/engine/simple_send.cpp ef8a5b1f45e5fb8575d138ccc3443f9a51d452d4 
  examples/cpp/helloworld.cpp f38037cc0727a8e5cf5c185991eda8d5ae196b6c 
  examples/cpp/helloworld_direct.cpp a87d87b6a9a8722245331d0791e1f88eedc06370 
  examples/cpp/queue_browser.cpp b160773aa33016f2befccb9a0a2474468684e8ad 
  examples/cpp/selected_recv.cpp 23dee018e5deea780e8b25cd1af745b49eebb14d 
  examples/cpp/server.cpp 95938eea3dfd5407012f21062abf6ea21f71686c 
  examples/cpp/server_direct.cpp 3dff34ad1af759c22f5fa1fff24ccdab2b53c738 
  examples/cpp/simple_recv.cpp 32f9417af2760f5aee8d1932e6adaa1b740169e0 
  examples/cpp/simple_send.cpp 95a66012601fd71f5c0ac6860ceadc20d1faa7dd 
  examples/cpp/ssl.cpp b792114a3158298a09860f453f0051bdf4aef10a 
  examples/cpp/ssl_client_cert.cpp 5c2b3ef31a099b3b0a02a93537ed50823dfc8dd9 
  proton-c/bindings/cpp/include/proton/connection.hpp 34600c04097ec21c1cb9f2a59f31250f8fbc07dc

  proton-c/bindings/cpp/include/proton/delivery.hpp 062cf8fa6845bb3131bd417c1784b1e45a9ab678

  proton-c/bindings/cpp/include/proton/handler.hpp e04b26e6d5fa8c397d9cd81f30c5799ffd6baaba

  proton-c/bindings/cpp/src/delivery.cpp 761d17ad09d09ce4c8cc9f5d295aee260ad395e8 
  proton-c/bindings/cpp/src/handler.cpp 59319de33cc68d44b83ebd1d77a4b2e7055405e0 
  proton-c/bindings/cpp/src/messaging_adapter.cpp 02e4bc6e5b44bac5a64867e553a8172fae9e9a83

  tests/tools/apps/cpp/reactor_send.cpp 541de1c5e44ddaf245d68045f01c525beb869f8c 

Diff: https://reviews.apache.org/r/45288/diff/


Testing
-------

Passes ctest -R cpp


Thanks,

Andrew Stitcher


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message