qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lorenz Quack (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (QPID-6764) Message age alerting is inappropriate on the enqueue path
Date Mon, 14 Mar 2016 15:00:39 GMT

    [ https://issues.apache.org/jira/browse/QPID-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193356#comment-15193356
] 

Lorenz Quack edited comment on QPID-6764 at 3/14/16 3:00 PM:
-------------------------------------------------------------

* It seems that in the {{NotificationCheck#MESSAGE_AGE_ALERT}}) has the wrong boolean flags
in the constructor (have I mentioned that I do not like boolean flags?)
* On {{AbstractQueue}} there is {{checkForNotification}} and {{performNotificationCheck}}.
That is not a useful distinction. However, it seems like {{checkForNotification}} is unused
and could be removed.
* {{checkForNotificationOnNewMessage}} and {{performNotificationCheck}} seem to be closely
related so we might want to consider naming them similar


was (Author: lorenz.quack):
* It seems that in the {{NotificationCheck#MESSAGE_AGE_ALERT) has the wrong boolean flags
in the constructor (have I mentioned that I do not like boolean flags?)
* On {{AbstractQueue}} there is {{checkForNotification}} and {{performNotificationCheck}}.
That is not a useful distinction. However, it seems like {{checkForNotification}} is unused
and could be removed.
* {{checkForNotificationOnNewMessage}} and {{performNotificationCheck}} seem to be closely
related so we might want to consider naming them similar

> Message age alerting is inappropriate on the enqueue path
> ---------------------------------------------------------
>
>                 Key: QPID-6764
>                 URL: https://issues.apache.org/jira/browse/QPID-6764
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Rob Godfrey
>             Fix For: qpid-java-6.1
>
>
> The Java Broker supports number of configurable message/queue alerts such as message
size alert (overly large messages), queue depth alert (queues with an unexpected number of
message on them), or message age alert (a queue containing a message which is older than a
threshold).  These checks are performed in two places: periodically by housekeeping and when
a message is enqueued.
> The message age alert check is performed on by housekeeping and on enqueue of a new message.
 The latter check is inappropriate and is a waste of resources.  Unlike the other checks,
enqueuing a message can't affect the outcome.  It should be performed only be housekeeping.
 
> The message age check involves taking a lock on the oldest message - so may have a significant
computation overhead.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message