qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chuck Rolke (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (DISPATCH-270) Specifying a maxSessions limit of 1 allows unlimited sessions
Date Mon, 11 Apr 2016 13:37:25 GMT

     [ https://issues.apache.org/jira/browse/DISPATCH-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chuck Rolke closed DISPATCH-270.
--------------------------------
       Resolution: Won't Fix
    Fix Version/s: 0.6

Dispatch is doing the right thing. However, based on what client you are running the results
are varied.

The AMQP.Net Lite client does not honor the channel-max=0 and limit the client to one session.
When Lite creates the second session then qpid-proton/qpid-dispatch core dumps. This is clearly
a protocol violation but it provides a trivial path to crashing dispatch router.
If channel-max > 0 then Lite refuses to create the sessions, no protocol violation, and
no crash.


> Specifying a maxSessions limit of 1 allows unlimited sessions
> -------------------------------------------------------------
>
>                 Key: DISPATCH-270
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-270
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Policy Engine
>    Affects Versions: 0.6
>            Reporter: Chuck Rolke
>             Fix For: 0.6
>
>
> This is an issue of cascading magic numbers. Policy keeps the numbers in normal human
readable form. The number is decremented when it's handed over to proton to put into channel-max.
> So a policy limit of 1 gets decremented to zero when sent to proton. Proton sees a zero
and sends no channel-max in the Open frame, allowing the maximum number of sessions.
> A user must specify two or more for the maxSessions in order to get the expected number.
> Dispatch router policy should fail when a user specifies maxSessions = 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message