qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Conway (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1226) Handler not set on inbound connection
Date Mon, 06 Jun 2016 14:31:20 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316554#comment-15316554

Alan Conway commented on PROTON-1226:

 Approved for 0.13.0. Fixes a regression in the container/reactor implementation (my bad,
implemented new listener interface without fully understanding the C reactor/handler relationship),
and fixes it in the right place with no impact on connection_engine based container implementations.

> Handler not set on inbound connection
> -------------------------------------
>                 Key: PROTON-1226
>                 URL: https://issues.apache.org/jira/browse/PROTON-1226
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: 0.13.0, 0.14.0
>            Reporter: Cliff Jansen
>            Assignee: Cliff Jansen
>             Fix For: 0.14.0
> Historically, the handler was always specified before the connection was created so that
the PN_CONNECTION_INIT could go to the correct handler, whereas the rest of the connection
options could only be applied later, after creation.
> For inbound connections, the handler was set on the listener (pn_reactor_acceptor())
and the reactor set it for the accepted connections.
> History has changed.  Nobody processes PN_CONNECTION_INIT except the global handler,
so deferred setting of the handler is probably OK, allowing the handler to be set at the same
time as the other non-transport options.
> Alternatively, the caller of on_accept() must separately apply the handler (which might
change per connection on a listener) to make the new listen_handler interface work as intended.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message