qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cliff Jansen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1226) Handler not set on inbound connection
Date Sat, 04 Jun 2016 21:02:59 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315632#comment-15315632
] 

Cliff Jansen commented on PROTON-1226:
--------------------------------------

I have a copy of the same fix in my copy of the 0.13 release branch:

  https://github.com/cliffjansen/qpid-proton/tree/cj13_pn1226

It compiles and runs ctest on rhel6 & 7 and Windows 7/VS 2008

Also the flow_control example runs fine with this patch.

The code is largely cut and pasted from other Proton C++ binding code, so I think it is unlikely
that it would introduce some new syntax error on some compiler.

> Handler not set on inbound connection
> -------------------------------------
>
>                 Key: PROTON-1226
>                 URL: https://issues.apache.org/jira/browse/PROTON-1226
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: 0.13.0, 0.14.0
>            Reporter: Cliff Jansen
>            Assignee: Cliff Jansen
>             Fix For: 0.14.0
>
>
> Historically, the handler was always specified before the connection was created so that
the PN_CONNECTION_INIT could go to the correct handler, whereas the rest of the connection
options could only be applied later, after creation.
> For inbound connections, the handler was set on the listener (pn_reactor_acceptor())
and the reactor set it for the accepted connections.
> History has changed.  Nobody processes PN_CONNECTION_INIT except the global handler,
so deferred setting of the handler is probably OK, allowing the handler to be set at the same
time as the other non-transport options.
> Alternatively, the caller of on_accept() must separately apply the handler (which might
change per connection on a listener) to make the new listen_handler interface work as intended.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message