qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
Date Fri, 16 Sep 2016 15:22:20 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496564#comment-15496564
] 

ASF GitHub Bot commented on PROTON-1303:
----------------------------------------

Github user alanconway commented on the issue:

    https://github.com/apache/qpid-proton/pull/81
  
    OOps no: I don't like that this is not allowed ":1234" becase it *is* allowed by the go
URL parser and is correctly interpreted as "listen on all interfaces" or "connect to localhost"
by the go runtimes. It is commonly used in go documentation, e.g .the standard way to start
the godoc webserver is 
      godoc -http :6060
    
    I'm starting to feel that there isn't much/any need for a special URL parser if we simply
provide the Update function to fill in defaults. Then we don't have to do anything to mess
with parsing/what is acceptable as a URL, we just provide AMQP info - which is our job



> Don't use the proton-c url parser
> ---------------------------------
>
>                 Key: PROTON-1303
>                 URL: https://issues.apache.org/jira/browse/PROTON-1303
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: go-binding
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>
> Go has it's own standard url parser - it doesn't need to use the rather odd and somewhat
error prone parser in proton-c.
> It will be useful to provide some ability to set appropriate defaults for supplied amqp
urls though.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message