qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alanconway <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #83: [Go binding] Replaced c handler based flowcont...
Date Wed, 12 Oct 2016 14:39:20 GMT
Github user alanconway commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/83#discussion_r83019429
  
    --- Diff: proton-c/bindings/go/src/qpid.apache.org/proton/handlers.go ---
    @@ -308,7 +316,7 @@ func (d *MessagingAdapter) HandleEvent(e Event) {
     			d,
     		}
     		if d.Prefetch > 0 {
    -			d.flowcontroller = cHandler{C.pn_flowcontroller(C.int(d.Prefetch))}
    +			d.flowcontroller = flowcontroller{ window:d.Prefetch, drained:0 }
    --- End diff --
    
    Go cases do not fall through by default so your first 3 cases do nothing. I think you
mean:
    
    switch e.Type() {
    case ELinkLocalOpen, ELinkRemoteOpen, ELinkFlow, Edelivery: ...
    
    Otherwise it is  a thing of beauty, should have done this ages ago. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message