qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-451) [AMQP] Hard coded session capacity should be configurable
Date Tue, 04 Oct 2016 18:05:20 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546167#comment-15546167
] 

ASF GitHub Bot commented on DISPATCH-451:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/106#discussion_r81817075
  
    --- Diff: include/qpid/dispatch/server.h ---
    @@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
         uint32_t max_frame_size;
     
         /**
    +     * The max_sessions value is the number of sessions allowed on the Connection. 
    +     * This value minus one is the Open performative channel-max setting.
    +     */
    +    uint32_t max_sessions;
    --- End diff --
    
    What will be do with the value 0?  Should we use channel_max to avoid this question?


> [AMQP] Hard coded session capacity should be configurable
> ---------------------------------------------------------
>
>                 Key: DISPATCH-451
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-451
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Container
>    Affects Versions: 0.6.0
>            Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 1000000);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions, Begin/incoming_window,
Attach/maxMessageSize. Configuration settings for these are also desirable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message