qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kgiusti <...@git.apache.org>
Subject [GitHub] qpid-proton issue #85: PROTON-1330: [python] bundle the C source in the pyth...
Date Mon, 14 Nov 2016 18:59:43 GMT
Github user kgiusti commented on the issue:

    https://github.com/apache/qpid-proton/pull/85
  
    re: encoding.h and protocol.h:
    
    I didn't want to duplicate the generation of these files in the python CMakeLists.txt
but as it stands now these files are generated during the build phase - not the cmake configuration
pass.   I can either 1) require the C compilation is done prior to building the Python source
distribution or 2) move the file generation to the cmake configuration phase.  
    
    re: packaging C source
    
    I'm not entirely sure I understand - are you suggesting some of the C files are not needed
by the Python bindings?  I assume I can hunt around for these files, but isn't all Proton/C
functionality accessible via the python bindings, since the binding is used by the python
unit tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message