qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ted-ross <...@git.apache.org>
Subject [GitHub] qpid-dispatch pull request #116: DISPATCH-572 - Added fprintf message that a...
Date Wed, 23 Nov 2016 18:59:04 GMT
Github user ted-ross commented on a diff in the pull request:

    --- Diff: src/server.c ---
    @@ -687,6 +688,11 @@ static void thread_process_listeners_LH(qd_server_t *qd_server)
                 pn_transport_set_tracer(tport, qd_transport_tracer);
    +        if (tport && ctx->pn_cxtr) {
    +           if (qdpn_connector_trace(ctx->pn_cxtr) & (PN_TRACE_FRM | PN_TRACE_RAW
    +               fprintf(stderr, "Transport [%p] on %s\n", tport, qdpn_connector_name(ctx->pn_cxtr));
    --- End diff --
    Why are you using fprintf when you should be using a log?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message