qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution
Date Mon, 07 Nov 2016 14:25:58 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644314#comment-15644314
] 

ASF GitHub Bot commented on PROTON-1330:
----------------------------------------

GitHub user kgiusti opened a pull request:

    https://github.com/apache/qpid-proton/pull/85

    PROTON-1330: [python] bundle the C source in the python source distriā€¦

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kgiusti/qpid-proton PROTON-1330

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit c917fe870e3f8e41a9ac7d295cc48cb08e002682
Author: Kenneth Giusti <kgiusti@apache.org>
Date:   2016-11-01T17:21:15Z

    PROTON-1330: [python] bundle the C source in the python source distribution

----


> Include the C sources in the python source distribution
> -------------------------------------------------------
>
>                 Key: PROTON-1330
>                 URL: https://issues.apache.org/jira/browse/PROTON-1330
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.15.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Blocker
>             Fix For: 0.16.0
>
>
> setup.py in the python bindings will download the proton-c sources from the apache dist
url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by apache infrastructure
maintainers.  This will lead to failures when installing python via setup.py (as is done via
pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the necessary proton-c
source files for inclusion in the python bindings package.  Instead of fetching the necessary
sources from apache, setup.py can simply build and install the proton library using the bundled
sources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message