qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1330) Include the C sources in the python source distribution
Date Tue, 15 Nov 2016 21:06:58 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668322#comment-15668322

ASF GitHub Bot commented on PROTON-1330:

Github user astitcher commented on a diff in the pull request:

    --- Diff: proton-c/bindings/python/CMakeLists.txt ---
    @@ -122,3 +129,55 @@ install(TARGETS ${SWIG_MODULE_cproton_REAL_NAME}
             COMPONENT Python)
     set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES "html;tutorial")
    +# Set up the directory 'dist' for building the python native package
    +# source distribution for Pypi/pip
    +set(py_dist_dir ${CMAKE_CURRENT_BINARY_DIR}/dist)
    +               ${py_dist_dir}/setup.py
    +               ${py_dist_dir}/README.rst
    +file(COPY ${py_dist_files} DESTINATION ${py_dist_dir})
    +file(MAKE_DIRECTORY ${py_dist_dir}/proton)
    +file(COPY ${pysrc} DESTINATION ${py_dist_dir}/proton)
    +#file(COPY ${py_dist_proton_c_files}
    --- End diff --
    Do you really want to add commented out lines?

> Include the C sources in the python source distribution
> -------------------------------------------------------
>                 Key: PROTON-1330
>                 URL: https://issues.apache.org/jira/browse/PROTON-1330
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.15.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Blocker
>             Fix For: 0.16.0
> setup.py in the python bindings will download the proton-c sources from the apache dist
url if proton is not installed.
> The source tarballs hosted at apache dist may be deleted at any time by apache infrastructure
maintainers.  This will lead to failures when installing python via setup.py (as is done via
pip for the pypi packages).
> We should modify the cmake build of the python bindings to package up the necessary proton-c
source files for inclusion in the python bindings package.  Instead of fetching the necessary
sources from apache, setup.py can simply build and install the proton library using the bundled

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message