qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7477) [Java Broker] Recovery of Broker preferences should happen without holding VirtualHostPrincipal
Date Thu, 03 Nov 2016 14:07:58 GMT

    [ https://issues.apache.org/jira/browse/QPID-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632813#comment-15632813
] 

ASF subversion and git services commented on QPID-7477:
-------------------------------------------------------

Commit 1767886 from orudyy@apache.org in branch 'java/branches/6.1.x'
[ https://svn.apache.org/r1767886 ]

QPID-7477: [Java Broker] Propagate the context subject from the thread that adds a future
callback to the task thread that executes it

Also ensure that future callbacks are always executed by the CO's task executor by using the
explicit three arg form of Futures.addCallback(). Previously some callbacks were executed
by a thread that completed the awaited future and not necessarily the desired one.

merged from trunk using
svn merge -c r1767825  ^/qpid/java/trunk

> [Java Broker] Recovery of Broker preferences should happen without holding VirtualHostPrincipal
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-7477
>                 URL: https://issues.apache.org/jira/browse/QPID-7477
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-6.1
>            Reporter: Lorenz Quack
>            Assignee: Keith Wall
>             Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> If a {{VirtualHostLogger}} is configured it will log the recovery of Broker preferences
on the Broker-Config thread. It should not do this.
> The cause seems to be that during execution of {{BrokerImpl#performActivation}} the {{Subject}}
contains the {{VirtualHostPrincipal}}.
> I think this is related to the fact that the call stack shows that this code is called
from the {{onSuccess}} callback of {{VirtualHostNode#doActivation}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message