qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7515) [Java Broker] Improve VirtualHost#publishMessage - take two
Date Sun, 04 Dec 2016 08:43:58 GMT

    [ https://issues.apache.org/jira/browse/QPID-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719583#comment-15719583

Keith Wall commented on QPID-7515:

For point 1, that we make the model capable of designating operation parameters as not null
(QPID-7571).  The branch, I suggest adding an if null check to the operation itself.
For point 2, the response is actually {{0}} indicating that the message was enqueued onto
no queues.  This is in the operation's API docs.   I think this is sufficient - I don't think
an log message is necessary.
Finally, for point 3, I verified that the JSON response in the test case contains the unencoded
response "bar".  The non JSON response is the serialised Java string - which as discussed
is expected behaviour.

> [Java Broker] Improve VirtualHost#publishMessage - take two
> -----------------------------------------------------------
>                 Key: QPID-7515
>                 URL: https://issues.apache.org/jira/browse/QPID-7515
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-6.1
>            Reporter: Lorenz Quack
>             Fix For: qpid-java-6.2, qpid-java-6.1.1
> There are still issues with VirtualHost#publishMessage:
> * if the REST request body contains an empty object ("{}") an (non-fatal) NPE occurs
on the broker and the client receives a 500
> * if the "address" argument is missing or incorrect the message is silently dropped (also
no log message). The client receives a 200 regardless.
> * Message download for messages published via REST seems broken in at least one case:
{{\{"message":\{"address":"foo","content":"bar","mimeType":"text/plain"\}\}}} appears correct
in the message preview in the View Message dialogue and the mimeType is also correct but when
downloading the message the content is not correctly encoded. I could not find an encoding
that gave me "bar". I did not investigate to see whether I could figure out what the bytes

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message