qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Wall (JIRA)" <j...@apache.org>
Subject [jira] [Created] (QPID-7582) Auto unboxing null from Discharge#getFail() cause NPEs
Date Thu, 08 Dec 2016 14:29:58 GMT
Keith Wall created QPID-7582:
--------------------------------

             Summary: Auto unboxing null from Discharge#getFail() cause NPEs
                 Key: QPID-7582
                 URL: https://issues.apache.org/jira/browse/QPID-7582
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker
            Reporter: Keith Wall
             Fix For: qpid-java-7.0.0


As highlighted by a NPE from TxnCoordinatorReceivingLink_1_0#discharge:151, the AMQP 1.0 
protocol layer assumes that {{Discharge#fail}} is never returns null.  The code  un-autoboxes
the object back to its primitive.    The spec allows it to be, so a NPE will results in this
situation.

We need to check all the implementation classes that back AMQP performative.  For any field
marked as optional which is of a type subject to auto-box, defensive code must be added.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message