qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7582) Auto unboxing null from Discharge#getFail() cause NPEs
Date Thu, 08 Dec 2016 14:42:58 GMT

    [ https://issues.apache.org/jira/browse/QPID-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732394#comment-15732394
] 

ASF subversion and git services commented on QPID-7582:
-------------------------------------------------------

Commit 1773248 from [~godfrer] in branch 'java/trunk'
[ https://svn.apache.org/r1773248 ]

QPID-7582 : Fix all unsafe auto-unboxing of boolean values in AMQP 1.0

> Auto unboxing null from Discharge#getFail() cause NPEs
> ------------------------------------------------------
>
>                 Key: QPID-7582
>                 URL: https://issues.apache.org/jira/browse/QPID-7582
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Keith Wall
>             Fix For: qpid-java-7.0.0
>
>
> As highlighted by a NPE from TxnCoordinatorReceivingLink_1_0#discharge:151, the AMQP
1.0  protocol layer assumes that {{Discharge#fail}} is never returns null.  The code  un-autoboxes
the object back to its primitive.    The spec allows it to be, so a NPE will results in this
situation.
> We need to check all the implementation classes that back AMQP performative.  For any
field marked as optional which is of a type subject to auto-box, defensive code must be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message