qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1312) BlockingConnection leaks Proton-C memory
Date Tue, 10 Jan 2017 18:30:58 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815763#comment-15815763
] 

ASF GitHub Bot commented on PROTON-1312:
----------------------------------------

Github user ssorj commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/93#discussion_r95426588
  
    --- Diff: proton-c/bindings/python/proton/utils.py ---
    @@ -132,10 +132,12 @@ def __init__(self, connection, receiver, fetcher, credit=1):
                 raise LinkException("Failed to open receiver %s, source does not match" %
self.link.name)
             if credit: receiver.flow(credit)
             self.fetcher = fetcher
    +        self.container = connection.container
     
         def __del__(self):
             self.fetcher = None
    -        self.link.handler = None
    +        self.link.handler = None  # fails if reactor finalizes first
    --- End diff --
    
    What happens with the error if it fails?  I suppose in that case it doesn't matter that
the subsequent statement is not reached?


> BlockingConnection leaks Proton-C memory
> ----------------------------------------
>
>                 Key: PROTON-1312
>                 URL: https://issues.apache.org/jira/browse/PROTON-1312
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.9, 0.15.0
>            Reporter: Cliff Jansen
>            Assignee: Cliff Jansen
>              Labels: leak, reproducer
>             Fix For: 0.17.0
>
>         Attachments: ml8.py
>
>
> The attached program leaks the underlying connection (the C proton
> object) associated with the BlockingConnection on each loop iteration
> on proton 0.9 as used by Satellite.  Without the receiver, it cleans
> up fine.
> On master, the program leaks both the reactor and the connection
> associated with the BlockingConnection for each loop.  The receiver
> creation can be commented out and it still leaks both objects.
> Other objects may leak too (presumably session), but I have not
> examined further.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message