qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Rudyy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPID-7576) Metadata loaded twice for recovered message
Date Wed, 04 Jan 2017 15:37:58 GMT

    [ https://issues.apache.org/jira/browse/QPID-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798522#comment-15798522

Alex Rudyy commented on QPID-7576:

I reviewed the changes committed under revision [r1775480|https://svn.apache.org/r1775480]
and here are my review comments:
* {{AbstractServerMessageImpl}}; It appears that after  implemented changes field _handle
cannot be null. IMHO, it make sense to add an explicit check into constructor for {{AbstractServerMessageImpl}}
to validate that handle is not null and throw {{ServerScopeRuntimeException}} if it is the
case. The comments at lines 112-113 seem redundant. The null check is redundant as well.
* Taking that  method {{getContentSize()}} is added into {{StoredMessage}}, it would make
sense to call it instead of {{StoredMessage.getMetaData().getContentSize()}} where appropriate.
I attached a patch with the suggested changes (0001-QPID-7576-Call-StoredMessage-getContentSize-where-ap.patch).
* {{AbstractConsumerTarget}}; The change made in send method look good but it seems that returned
value is never used. I am wondering whether we really need to return the value from this method.
If signature of method in {{ConsumerTarget}} is changed to return void, the implemented change
in {{AbstractConsumerTarget#send}} would not be necessary. 

> Metadata loaded twice for recovered message
> -------------------------------------------
>                 Key: QPID-7576
>                 URL: https://issues.apache.org/jira/browse/QPID-7576
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-7.0
>            Reporter: Keith Wall
>             Fix For: qpid-java-7.0
>         Attachments: 0001-QPID-7576-Call-StoredMessage-getContentSize-where-ap.patch,
> For recovered messages (and possibly messages that have been flown to disk), the metadata
is evacuated from memory unnecessarily and then immediately reloaded.  

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message