qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (QPID-7605) [Java Broker] [AMQP1.0] Container id uniqueness
Date Wed, 04 Jan 2017 17:37:58 GMT

    [ https://issues.apache.org/jira/browse/QPID-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798831#comment-15798831
] 

Robbie Gemmell edited comment on QPID-7605 at 1/4/17 5:37 PM:
--------------------------------------------------------------

Of course, reading through all the comments again, and thinking back more on some of the details
around the ClientID thing, I think actually the intent was just that servers could always
send the "amqp:connection-establishment-failed" property during 'open failure', with that
alone being enough to indicate whats going on. The property map is already there, and just
looking at it is a simpler client(/peer/server) change than needing to set a desired capability
and inspect if its supported on the reply frame and then check the container-id. That we happened
to have the capability bits for JMS for the ClientID check was due to that being a specific
added reason to provoke the failure.

Hehe yes, you'll need to give them a mail I think (I renamed and recreated my account...then
had to mail to get the old one removed as you couldnt do that yourself :P)


was (Author: gemmellr):
Of course, reading through all the comments again, and thinking back more on some of the details
around the ClientID thing, I think actually the intent was just that servers could always
send the "amqp:connection-establishment-failed" property during 'open failure', with that
alone being enough to indicate whats going on. he property map is already there, and just
looking at it is a simpler client(/peer/server) change than needing to set a desired capability
and inspect if its supported on the reply frame and then check the container-id. That we happened
to have the capability bits for JMS for the ClientID check was due to that being a specific
added reason to provoke the failure.

Hehe yes, you'll need to give them a mail I think (I renamed and recreated my account...then
had to mail to get the old one removed as you couldnt do that yourself :P)

> [Java Broker] [AMQP1.0] Container id uniqueness
> -----------------------------------------------
>
>                 Key: QPID-7605
>                 URL: https://issues.apache.org/jira/browse/QPID-7605
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>             Fix For: qpid-java-7.0
>
>
> The AMQP 1.0 protocol layer implementation must ensure that the AMQP Open performative
container-id is unique amongst existing established connections.
> As the JMS client id maps to the container-id, so this will fulfil the JMS requirement.
 
> https://docs.oracle.com/javaee/7/api/javax/jms/Connection.html#setClientID-java.lang.String-
> Note that the Qpid JMS Client requires the Close performative with an Error containing
a hint to generate to correct JMS exception.  How will the Qpid Broker know to do this?
> org.apache.qpid.jms.integration.FailedConnectionsIntegrationTest#testConnectWithInvalidClientIdThrowsICIDEWhenInvalidContainerHintPresent



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message