qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ted-ross <...@git.apache.org>
Subject [GitHub] qpid-dispatch pull request #142: DISPATCH-628: Multiple connections per auto...
Date Fri, 03 Feb 2017 16:22:04 GMT
Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/142#discussion_r99370107
  
    --- Diff: src/router_core/route_control.c ---
    @@ -396,7 +408,18 @@ void qdr_route_connection_closed_CT(qdr_core_t *core, qdr_connection_t
*conn)
                 al = DEQ_NEXT_N(REF, al);
             }
     
    -        cid->open_connection = 0;
    +        //
    +        // Remove our own entry in the connection list
    +        //
    +        qdr_connection_ref_t * cref = DEQ_HEAD(cid->connection_refs);
    +        while (cref) {
    +            if (cref->conn == conn) {
    +                DEQ_REMOVE(cid->connection_refs, cref);
    --- End diff --
    
    I believe this will leak one qdr_connection_ref_t each time it is run.  Why did you not
use qdr_del_connection_ref?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message