qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DISPATCH-628) [PATCH] Multiple connections per autoLink and linkRoute overwrites connection handle
Date Fri, 03 Feb 2017 10:32:51 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851312#comment-15851312
] 

ASF GitHub Bot commented on DISPATCH-628:
-----------------------------------------

GitHub user lulf opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/142

    DISPATCH-628: Multiple connections per autoLink and linkRoute overwrites connection handle

    This ensures that an autolink and linkroute can be bound to more than one
    connection. The assert checking this is disabled in optimized builds and was
    never triggered.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lulf/qpid-dispatch DISPATCH-628

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit 49d95b767ca5ee8fc9d0dadb3951c799e4ec89ba
Author: Ulf Lilleengen <lulf@redhat.com>
Date:   2017-02-03T09:58:19Z

    DISPATCH-628: Multiple connections per autoLink and linkRoute overwrites connection handle
    
    This ensures that an autolink and linkroute can be bound to more than one
    connection. The assert checking this is disabled in optimized builds and was
    never triggered.

----


> [PATCH] Multiple connections per autoLink and linkRoute overwrites connection handle
> ------------------------------------------------------------------------------------
>
>                 Key: DISPATCH-628
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-628
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Ulf Lilleengen
>
> When implementing https://github.com/apache/qpid-dispatch/pull/111 I stumbled across
an issue with an autoLink or linkRoute only being able to refer to more than 1 connection,
which I assumed would originaly cause an assert in route_control.c:350 to trigger when I configured
an autoLink to trigger on a containerId and use the same container id when sharding a queue.
> Since the assert didn't trigger, I assumed that I must have misread the code, but nontheless
as part of the patch I made it possible for a linkRoute/autoLink to be associated with multiple
connections.
> Recently, I have seen some router crashes when scaling up and down queues in EnMasse,
and I just figured that the reason for this assert not triggering is that it is disabled in
the RelWithDebInfo configuration. 
> If built without optimizations (Debug), I'm able to trigger the issue with the configuration
in http://people.redhat.com/~ulilleen/bugs/routerconn/  
> To trigger, I startup the router and broker as so:
> qdrouterd -c router_incoming.conf
> export MESSAGING_SERVICE_HOST=localhost 
> export MESSAGING_SERVICE_PORT_INTERNAL=55673
> export QUEUE_NAME=myqueue
> export CONTAINER_ID=myqueue
> ./br/bin/simplebroker &
> ./br/bin/simplebroker
> I have extracted the patch from DISPATCH-476 and will create a PR with it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message