qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ted-ross <...@git.apache.org>
Subject [GitHub] qpid-dispatch pull request #143: DISPATCH-597 - Added ability to selectively...
Date Wed, 01 Mar 2017 18:12:13 GMT
Github user ted-ross commented on a diff in the pull request:

    --- Diff: src/router_node.c ---
    @@ -226,9 +227,22 @@ static void AMQP_rx_handler(void* context, qd_link_t *link, pn_delivery_t
         //        send it.
         msg = qd_message_receive(pnd);
         if (!msg)
    +    char repr[qd_message_repr_len()];
    --- End diff --
    This declaration should be inside the if statement.  You are needlessly allocating stack
space when logging is disabled.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message