qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Stitcher <astitc...@apache.org>
Subject Re: Review Request 57702: NO-JIRA: c++ binding - removed circular #define
Date Fri, 17 Mar 2017 02:38:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57702/#review169250
-----------------------------------------------------------



This looks good: Note there is also a PN_WEAKREF object type which might also solve the problem,
but I'm not entirely sure.


proton-c/src/proactor/libuv.c
Lines 252 (patched)
<https://reviews.apache.org/r/57702/#comment241595>

    Might be slightly more idiomatic/clearer to use ```sizeof(pconnection_t)``` here, but
it amounts to the same thing.


- Andrew Stitcher


On March 16, 2017, 8:41 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57702/
> -----------------------------------------------------------
> 
> (Updated March 16, 2017, 8:41 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Cliff Jansen.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> -------
> 
> PROTON-1440: libuv proactor - thread safe pn_connection_wake
> 
> This fix does not change the API but makes pn_connection_wake thread safe.
> 
> To be thread safe we need to a lock, so the pconnection_t attachment stays
> on the pn_connection_t until the pn_connection_t is destroyed.
> 
> pn_proactor_free also was modified to run the normal socket close sequence
> rather than a short-cut that just closes TCP sockets - this allows the
> wake locking logic to run as normal, even if the application calls wake
> after the proactor is freed.
> 
> also at https://github.com/alanconway/qpid-proton/tree/safe-wake
> 
> 
> Diffs
> -----
> 
>   proton-c/bindings/cpp/src/contexts.cpp 8da8f7cf5b64c75e7eaddc27069b8a7160e6f9d6 
>   proton-c/src/proactor/libuv.c 102fcdd8a30d2dd57d9545552bcfd695a251a66d 
>   proton-c/src/tests/proactor.c beba46e84c75fb36677576b645fd2f39bb238827 
> 
> 
> Diff: https://reviews.apache.org/r/57702/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message