qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitcher <...@git.apache.org>
Subject [GitHub] qpid-proton pull request #99: PROTON-1408 -- fix for msg id rollover bug
Date Mon, 27 Mar 2017 14:58:01 GMT
Github user astitcher commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/99#discussion_r108192064
  
    --- Diff: proton-c/src/core/transport.c ---
    @@ -1620,12 +1622,12 @@ static int pn_scan_error(pn_data_t *data, pn_condition_t *condition,
const char
     }
     
     /*
    -  This operator, copied from code for the qpid cpp broker, gives the correct
    +  This operator, inspired by code for the qpid cpp broker, gives the correct
       result when comparing sequence numbers implemented in a signed integer type.
     */
    -static bool sequence_less_than ( pn_sequence_t a, pn_sequence_t b )
    +static bool sequence_cmp ( pn_sequence_t a, pn_sequence_t b )
    --- End diff --
    
    This should be ```inline```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message