qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ganesh Murthy (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (DISPATCH-611) Router core dump with old config file
Date Mon, 06 Mar 2017 18:38:33 GMT

    [ https://issues.apache.org/jira/browse/DISPATCH-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897796#comment-15897796
] 

Ganesh Murthy edited comment on DISPATCH-611 at 3/6/17 6:38 PM:
----------------------------------------------------------------

The attached config file "oops.conf" does not have a router section (entity). The router section
is mandatory even in legacy config files. 

The following text must be added to the description of the "router" entity in qdrouter.json
to make it clear that router is a mandatory entity without which the router will not start
- 

{noformat}
"description":"Tracks peer routers and computes routes to destinations. This entity is mandatory.
The router will not start without this entity",
{noformat}

Codewise, the assert must be replaced with an exit so that router does not even start

Replace this asset - 
{noformat}
assert(qd->router_id);
{noformat}

with
{noformat}
    if (!qd->router_id) {
        qd_log_source_t *router_log = qd_log_source("ROUTER");
        qd_log(router_log, QD_LOG_CRITICAL, "Router Id not specified - process exiting");
        exit(1);
    }
{noformat}



was (Author: ganeshmurthy):
The attached config file "oops.conf" does not have a router section (entity). The router section
is mandatory even in old config files. 

The following text must be added to the description of the "router" entity in qdrouter.json
to make it clear that router is a mandatory entity without which the router will not start
- 

{noformat}
"description":"Tracks peer routers and computes routes to destinations. This entity is mandatory.
The router will not start without this entity",
{noformat}

Codewise, the assert must be replaced with an exit so that router does not even start

Replace this asset - 
{noformat}
assert(qd->router_id);
{noformat}

with
{noformat}
    if (!qd->router_id) {
        qd_log_source_t *router_log = qd_log_source("ROUTER");
        qd_log(router_log, QD_LOG_CRITICAL, "Router Id not specified - process exiting");
        exit(1);
    }
{noformat}


> Router core dump with old config file
> -------------------------------------
>
>                 Key: DISPATCH-611
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-611
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>         Environment: Linux hostname 4.8.13-100.fc23.x86_64 #1 SMP Fri Dec 9 14:51:40
UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Chuck Rolke
>            Assignee: Ganesh Murthy
>         Attachments: oops.conf
>
>
> Revving up an old config file causes a core dump.
> {noformat}
> > ./qdrouterd -c oops.conf  -I /home/user/git/qpid-dispatch/python
> qdrouterd: /home/user/git/qpid-dispatch/src/dispatch.c:162: qd_dispatch_configure_router:
Assertion `qd->router_id' failed.
> Aborted (core dumped)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message