qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (QPIDJMS-274) Be able to REJECT messages in JmsRedeliveryPolicy
Date Sat, 18 Mar 2017 22:43:42 GMT

    [ https://issues.apache.org/jira/browse/QPIDJMS-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931432#comment-15931432
] 

ASF GitHub Bot commented on QPIDJMS-274:
----------------------------------------

GitHub user fjollberg opened a pull request:

    https://github.com/apache/qpid-jms/pull/5

    Make it possible to choose type of acknowledge for redeliveries [QPIDJMS-274]

    This is left here as a base for discussion. I want to be able to choose the acknowledge
type for messages rejected by a custom JmsRedeliveryPolicy. I added a request to Jira: QPIDJMS-274,
https://issues.apache.org/jira/browse/QPIDJMS-274
    
    The particular use case is that I want to be able to do explicit dead lettering with Azure
Service Bus in a Camel route where I do redeliveries in Camel, and if failing explicitely
dead letter the messages with an amqp reject in order to avoid issues with message order to
the extent possible.
    
    This code works, but include an interface change. Would something like this be feasible?
Or am I missing something completely?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fjollberg/qpid-jms master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-jms/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit e40cd80d7da9b0860496125ef01cb7697e5e52a7
Author: Fredrik Jönsson <fjo@kth.se>
Date:   2017-03-18T22:23:16Z

    Make it possible to choose type of acknowledge for messages rejected
    by a custom JmsRedeliveryPolicy.

----


> Be able to REJECT messages in JmsRedeliveryPolicy
> -------------------------------------------------
>
>                 Key: QPIDJMS-274
>                 URL: https://issues.apache.org/jira/browse/QPIDJMS-274
>             Project: Qpid JMS
>          Issue Type: Improvement
>          Components: qpid-jms-client
>    Affects Versions: 0.21.0
>            Reporter: Fredrik Jönsson
>
> This is a placeholder for discussion right now, I believe I could implement it myself,
but would like suggestions as to how to do so in an acceptable manner for inclusion in the
project in that case if there are opinions about it.
> I would like to optionally (by configuration) *reject* messages with
> JmsRedeliveryPolicy/DefaultJmsRedeliveryPolicy, rather than respond with modify_undeliverable.
> The particular use case I have is a client reading from Azure Service Bus. I want it
to be able to reject messages that it knows to be undeliverable to explicitly dead-letter
them immediately.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message