qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fjollberg <...@git.apache.org>
Subject [GitHub] qpid-jms pull request #5: Make it possible to choose type of acknowledge for...
Date Sat, 18 Mar 2017 22:43:09 GMT
GitHub user fjollberg opened a pull request:

    https://github.com/apache/qpid-jms/pull/5

    Make it possible to choose type of acknowledge for redeliveries [QPIDJMS-274]

    This is left here as a base for discussion. I want to be able to choose the acknowledge
type for messages rejected by a custom JmsRedeliveryPolicy. I added a request to Jira: QPIDJMS-274,
https://issues.apache.org/jira/browse/QPIDJMS-274
    
    The particular use case is that I want to be able to do explicit dead lettering with Azure
Service Bus in a Camel route where I do redeliveries in Camel, and if failing explicitely
dead letter the messages with an amqp reject in order to avoid issues with message order to
the extent possible.
    
    This code works, but include an interface change. Would something like this be feasible?
Or am I missing something completely?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fjollberg/qpid-jms master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-jms/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit e40cd80d7da9b0860496125ef01cb7697e5e52a7
Author: Fredrik J├Ânsson <fjo@kth.se>
Date:   2017-03-18T22:23:16Z

    Make it possible to choose type of acknowledge for messages rejected
    by a custom JmsRedeliveryPolicy.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message