qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robbie Gemmell (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (PROTON-1436) Make EncoderImpl non-final
Date Tue, 18 Apr 2017 09:49:41 GMT

     [ https://issues.apache.org/jira/browse/PROTON-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Robbie Gemmell resolved PROTON-1436.
    Resolution: Won't Fix

Like Rob, I would say it is not anticipated that people would be extending these classes so
changing the encoder to allow that at this stage seems to send the wrong message, especially
given its quite likely to change in future releases.

> Make EncoderImpl non-final
> --------------------------
>                 Key: PROTON-1436
>                 URL: https://issues.apache.org/jira/browse/PROTON-1436
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: proton-j-0.18.0
>         Environment: NA
>            Reporter: Rick Parker
>            Priority: Minor
>             Fix For: proton-j-0.19.0
>   Original Estimate: 1h
>  Remaining Estimate: 1h
> org.apache.qpid.proton.codec.EncoderImpl is final.  org.apache.qpid.proton.codec.DecoderImpl
is non-final.    I'm working on a use case where it would be great to override EncoderImpl.getTypeFromClass()
to dynamically register described types as they are encountered (and do not implement DescribedType),
but I cannot currently do so due to the class being final.  I have to walk the object graph
first to register types, or fork the code and change EncoderImpl myself.
> Or perhaps there's a reason it is final?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

View raw message