qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1453) pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
Date Thu, 06 Apr 2017 19:08:41 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959548#comment-15959548
] 

ASF subversion and git services commented on PROTON-1453:
---------------------------------------------------------

Commit 6aefc4d2338ba5c91080665eb13f1740407edeb4 in qpid-proton's branch refs/heads/master
from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6aefc4d ]

NO-JIRA: revert temporary workaround for PROTON-1453


> pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
> ------------------------------------------------------------------------
>
>                 Key: PROTON-1453
>                 URL: https://issues.apache.org/jira/browse/PROTON-1453
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.17.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.18.0
>
>
> the pn_ssl_get_password/cipher_name method takes a target buffer and length and if the
name is known it is copied to the buffer (null terminated) and true is returned.
> However if the name is not known (not yet present) the method returns false and leaves
the buffer untouched.
> This is fine for correctly behaving C programs, but the swig generated code always assumes
the output buffer contains a properly terminated string whether or not the return value is
true.   The swigged code unconditionally calls strlen() on the returned buffer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message