qpid-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PROTON-1453) pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
Date Thu, 13 Apr 2017 14:11:41 GMT

    [ https://issues.apache.org/jira/browse/PROTON-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967629#comment-15967629
] 

ASF GitHub Bot commented on PROTON-1453:
----------------------------------------

Github user gemmellr commented on the issue:

    https://github.com/apache/qpid-proton/pull/102
  
    Looks like the change was applied, but was no longer the head commit at the time, and
didn't have "This closes #102" in the message of the commit itself or a merge commit. Can
you close it?


> pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
> ------------------------------------------------------------------------
>
>                 Key: PROTON-1453
>                 URL: https://issues.apache.org/jira/browse/PROTON-1453
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.17.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.18.0
>
>
> the pn_ssl_get_password/cipher_name method takes a target buffer and length and if the
name is known it is copied to the buffer (null terminated) and true is returned.
> However if the name is not known (not yet present) the method returns false and leaves
the buffer untouched.
> This is fine for correctly behaving C programs, but the swig generated code always assumes
the output buffer contains a properly terminated string whether or not the return value is
true.   The swigged code unconditionally calls strlen() on the returned buffer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Mime
View raw message